-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][ml] Don't estimate number of entries when ledgers are empty, return 1 instead #24125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-dont-use-default-size-when-ledger-is-empty
Mar 26, 2025
Merged
[fix][ml] Don't estimate number of entries when ledgers are empty, return 1 instead #24125
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-dont-use-default-size-when-ledger-is-empty
Mar 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24125 +/- ##
============================================
+ Coverage 73.57% 74.17% +0.59%
+ Complexity 32624 32457 -167
============================================
Files 1877 1864 -13
Lines 139502 144452 +4950
Branches 15299 16472 +1173
============================================
+ Hits 102638 107142 +4504
+ Misses 28908 28844 -64
- Partials 7956 8466 +510
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
approved these changes
Mar 26, 2025
dao-jun
approved these changes
Mar 26, 2025
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…turn 1 instead (apache#24125) (cherry picked from commit 228a98f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 27, 2025
…turn 1 instead (apache#24125) (cherry picked from commit 228a98f) (cherry picked from commit c6a9bee)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…turn 1 instead (apache#24125) (cherry picked from commit 228a98f) (cherry picked from commit c6a9bee)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…turn 1 instead (apache#24125) (cherry picked from commit 228a98f) (cherry picked from commit e2e0128)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…turn 1 instead (apache#24125) (cherry picked from commit 228a98f) (cherry picked from commit e2e0128)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.11
release/3.3.6
release/4.0.4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on #24089 changes. The changes cause a regression which is visible in branch-3.0 where a test fails (
org.apache.pulsar.compaction.CompactionTest#testDispatcherMaxReadSizeBytes). This test is different in newer branches. The regression is caused by the logic added in #24089 to useDEFAULT_ESTIMATED_ENTRY_SIZE + BOOKKEEPER_READ_OVERHEAD_PER_ENTRYas the default average entry size.Another gap is that when all ledgers are empty, no average size would be used. That is also fixed in this PR
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete