[fix][ml] Return 1 when bytes size is 0 or negative for entry count estimation #24131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry count estimation
lhotari
requested review from
Technoboy-,
dao-jun,
heesung-sohn,
merlimat,
nodece,
poorbarcode and
shibd
4 tasks
nodece
approved these changes
Mar 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24131 +/- ##
============================================
+ Coverage 73.57% 74.25% +0.68%
+ Complexity 32624 32492 -132
============================================
Files 1877 1864 -13
Lines 139502 144453 +4951
Branches 15299 16479 +1180
============================================
+ Hits 102638 107265 +4627
+ Misses 28908 28733 -175
- Partials 7956 8455 +499
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…stimation (apache#24131) (cherry picked from commit 82d3902)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 27, 2025
…stimation (apache#24131) (cherry picked from commit 82d3902) (cherry picked from commit e0a4d56)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…stimation (apache#24131) (cherry picked from commit 82d3902) (cherry picked from commit e0a4d56)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 28, 2025
…stimation (apache#24131) (cherry picked from commit 82d3902) (cherry picked from commit e40c0b8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…stimation (apache#24131) (cherry picked from commit 82d3902) (cherry picked from commit e40c0b8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…stimation (apache#24131) (cherry picked from commit 82d3902) (cherry picked from commit e40c0b8)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on #24089 changes. The changes cause a regression which is visible in branch-3.0 where a test fails (
org.apache.pulsar.sql.presto.TestCacheSizeAllocator#cacheSizeAllocatorTest). This test is missing from newer branches. The regression is caused by the logic added in #24089 to return 0 when bytes size <= 0.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete