[fix][test] Fix invalid test CompactionTest.testDeleteCompactedLedgerWithSlowAck

[lhotari]

Motivation

The test CompactionTest.testDeleteCompactedLedgerWithSlowAck fails with PR #23980. The test appears to be invalid and needs to be revisited.

Modifications

• revisit CompactionTest.testDeleteCompactedLedgerWithSlowAck
• replace the usage of long deprecated topic naming format where the cluster name is part of the topic name
  • "Many test classes are using deprecated topic naming format V1 which includes the cluster name" on dev mailing list
    • I'm planning to do this modification to other test classes later
  • this format is not compatible with topic policies
• improve the CompactionTest test class by doing some other cleanup such are using static imports for assertion methods.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[nodece]

LGTM.

However, this PR changes the topic name format from v1 to v2, which I am concerned will cause a conflict when cherry-picking this PR to the maintenance branches.

Would make sense that create a new PR to improve that?

[lhotari]

LGTM.  However, this PR changes the topic name format from v1 to v2, which I am concerned will cause a conflict when cherry-picking this PR to the maintenance branches.

Would make sense that create a new PR to improve that?

It was necessary to change to v2 for the single test case so that topic policies can be used. Topic policies fail with v1 topics. Because of consistency, I changed the complete test class to use v2 topic format.

@nodece I can handle resolving merge conflicts while cherry-picking, so no need to worry about that. I have a pretty good workflow for merge conflict resolution so that's not a big problem in this case.

[dao-jun]

lgtm