[fix][test] Fix more Netty ByteBuf leaks in tests #24299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
BewareMyPower,
Technoboy-,
dao-jun,
heesung-sohn,
liangyepianzhou and
nodece
dao-jun
approved these changes
May 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24299 +/- ##
============================================
+ Coverage 73.57% 74.18% +0.61%
+ Complexity 32624 32222 -402
============================================
Files 1877 1866 -11
Lines 139502 145059 +5557
Branches 15299 16581 +1282
============================================
+ Hits 102638 107615 +4977
- Misses 28908 28923 +15
- Partials 7956 8521 +565
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
added a commit
that referenced
this pull request
May 14, 2025
(cherry picked from commit 174245d)
lhotari
added a commit
that referenced
this pull request
May 14, 2025
(cherry picked from commit 174245d)
lhotari
added a commit
that referenced
this pull request
May 14, 2025
(cherry picked from commit 174245d)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
(cherry picked from commit 174245d)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixing Netty ByteBuf leaks in test code is needed for executing the plan explained in Enhancing Pulsar CI with Netty leak detection and reporting. The Pulsar CI Netty leak detection and reporting solution was added in #24272.
Modifications
org.apache.pulsar.broker.service.persistent.PersistentStickyKeyDispatcherMultipleConsumersClassicTest(pulsar-broker)org.apache.pulsar.broker.service.persistent.PersistentStickyKeyDispatcherMultipleConsumersTest(pulsar-broker)org.apache.pulsar.client.impl.AcknowledgementsGroupingTrackerTest(pulsar-client)org.apache.pulsar.client.impl.BinaryProtoLookupServiceTest(pulsar-client)org.apache.pulsar.client.impl.ClientCnxTest(pulsar-client)In addition, there are refactorings and improvements in the tests. For example, the redelivery test cases in
PersistentStickyKeyDispatcherMultipleConsumersClassicTestandPersistentStickyKeyDispatcherMultipleConsumersTestweren't properly testing the behavior. This has been fixed by properly mocking relevant ManageCursor's methods.Documentation
docdoc-requireddoc-not-neededdoc-complete