-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][io][branch-3.0]Pulsar-SQL: Fix classcast ex when decode decimal value #24317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
poorbarcode
merged 4 commits into
apache:branch-3.0
from
poorbarcode:fix/pulsar_sql_class_cast
May 21, 2025
Merged
[fix][io][branch-3.0]Pulsar-SQL: Fix classcast ex when decode decimal value #24317
poorbarcode
merged 4 commits into
apache:branch-3.0
from
poorbarcode:fix/pulsar_sql_class_cast
May 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poorbarcode Please add the following content to your PR description and select a checkbox: |
Technoboy-
approved these changes
May 20, 2025
codelipenghui
approved these changes
May 20, 2025
lhotari
reviewed
May 20, 2025
...o-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/json/PulsarJsonFieldDecoder.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
May 20, 2025
…resto/decoder/json/PulsarJsonFieldDecoder.java Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Contributor
Author
|
Please do not merge this PR so far, I am fixing an issue |
Contributor
Author
Sorry, I tested with the wrong code, so there is no issue |
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 28, 2025
… value (apache#24317) Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 396a8ee)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
… value (apache#24317) Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 29, 2025
… value (apache#24317) Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 396a8ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.12
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The original implementation of decoding was introduced by #15687, The implementation is as follows
#20016 introduced a break change, which added a classcast from
objecttoDecimalNode, The implementation was changed to as followsModifications
Revert the implementation to the original.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x