Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented May 21, 2025

Motivation

Fixing Netty ByteBuf leaks in test code is needed for executing the plan explained in Enhancing Pulsar CI with Netty leak detection and reporting. The Pulsar CI Netty leak detection and reporting solution was added in #24272.

While working on this PR, I found a real production code issue. That is fixed in a separate PR, #24331.

Modifications

  • Fix ByteBuf leaks in these tests
    • ManagedLedgerTest
    • TripleLongPriorityQueueTest
    • BlobStoreManagedLedgerOffloaderStreamingTest
    • BlobStoreManagedLedgerOffloaderTest

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone May 21, 2025
@lhotari lhotari self-assigned this May 21, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 21, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (bbc6224) to head (2efe986).
Report is 1113 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24332      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.67%     
+ Complexity    32624    32203     -421     
============================================
  Files          1877     1866      -11     
  Lines        139502   145124    +5622     
  Branches      15299    16593    +1294     
============================================
+ Hits         102638   107756    +5118     
+ Misses        28908    28825      -83     
- Partials       7956     8543     +587     
Flag Coverage Δ
inttests 26.66% <ø> (+2.08%) ⬆️
systests 23.26% <ø> (-1.06%) ⬇️
unittests 73.74% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1084 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 08866f2 into apache:master May 22, 2025
54 checks passed
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants