Corrected test case ProxyAuthenticationTest and ProxyPublishConsumeWi… #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roxyPublishConsumeWithoutZK
jai1
force-pushed
the
FixProxyPublishConsumeTest
branch
from
a770554 to
0fb83ee
Compare
merlimat
approved these changes
Feb 24, 2017
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Upgrade klauspost/compress to v1.10.5 * Fix zstdProvider.Decompress memory leak
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Fixes apache#230 The offset field is not filled when a PRODUCE request is processed yet. It causes that the offset what Kafka producer get from send()'s callback is always -1, which may cause some problems like apache#241 mentioned. This PR fills the offset field and add a unit test to verify if the right offset is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thoutZKTest
Motivation
Possible fix for #237
Can't replicate the timeout error but have seen the test case fail if the port is used by some other process
Modifications
Removed hardcoding for port 6080 and used the next free available port
Result
Hopefully the intermittent test case failures will reduce.