Skip to content

[fix][broker] fix getMaxReadPosition in TransactionBufferDisable should return latest #24898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 2 commits into from
Nov 3, 2025
Merged

[fix][broker] fix getMaxReadPosition in TransactionBufferDisable should return latest #24898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4734422
fix getMaxReadPosition in TransactionBufferDisable should return latest
Oct 28, 2025
9df0df5
fix getLastPosition in handleGetLastMessageId()
Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4140,6 +4140,12 @@ public CompletableFuture<Position> getLastDispatchablePosition() {
if (lastDispatchablePosition != null) {
return CompletableFuture.completedFuture(lastDispatchablePosition);
}
Position lastPosition;
if (transactionBuffer instanceof TransactionBufferDisable) {
lastPosition = getLastPosition();
} else {
lastPosition = getMaxReadPosition();
}
return ledger.getLastDispatchablePosition(entry -> {
MessageMetadata md = entry.getMessageMetadata();
if (md == null) {
Expand All @@ -4154,7 +4160,7 @@ public CompletableFuture<Position> getLastDispatchablePosition() {
return !isTxnAborted(txnID, entry.getPosition());
}
return true;
}, getMaxReadPosition()).thenApply(position -> {
}, lastPosition).thenApply(position -> {
// Update lastDispatchablePosition to the given position
updateLastDispatchablePosition(position);
return position;
Expand Down
3 changes: 2 additions & 1 deletion .../main/java/org/apache/pulsar/broker/transaction/buffer/impl/TransactionBufferDisable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.concurrent.CompletableFuture;
import lombok.extern.slf4j.Slf4j;
import org.apache.bookkeeper.mledger.Position;
import org.apache.bookkeeper.mledger.PositionFactory;
import org.apache.pulsar.broker.service.BrokerServiceException;
import org.apache.pulsar.broker.service.Topic;
import org.apache.pulsar.broker.service.persistent.PersistentTopic;
Expand Down Expand Up @@ -108,7 +109,7 @@ public void syncMaxReadPositionForNormalPublish(Position position, boolean isMar

@Override
public Position getMaxReadPosition() {
return topic.getLastPosition();
return PositionFactory.LATEST;
}

@Override
Expand Down
Loading