[improve][broker] Change log level from warn to debug when cursor mark-deleted position ledger doesn't exist#25200
Conversation
… ledger doesn't exist It's possible that the ledger at the mark-deleted position is empty and has been deleted already. This is not an error condition, so it should be logged at debug level instead of warn level to reduce noise in production logs. Fixes apache#20408
4055349 to
0c2dd96
Compare
I'm wondering if the fix in this PR is reasonable: #25117. The goal is to keep the ledger data and the mark-deleted position consistent, thereby eliminating similar warning logs. |
IMO, we should only change the mark-deleted position of a cursor when there's an actual user acknowledgment. Here's why:
|
…k-deleted position ledger doesn't exist (#25200)
…k-deleted position ledger doesn't exist (apache#25200) (cherry picked from commit 441e4ca)
…k-deleted position ledger doesn't exist (apache#25200) (cherry picked from commit 441e4ca)
Motivation
Fixes #20408
It's possible that the ledger at the mark-deleted position is empty and has been deleted already. This is not an error condition, so it should be logged at debug level instead of warn level to reduce noise in production logs.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Shawyeok#25