Adding option to use TLS in broker admin client. #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Oct 24, 2018
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
We need to have some unit test to verify the broker-broker tls config
Contributor
There was a problem hiding this comment.
We cannot just remove the old config key or we'd break compatibility.
We need to keep it and mark it as @Deprecated
Contributor
Author
|
@merlimat - addressed your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bug fix for #2830
Modifications
replicationTlsEnabledtobrokerClientTlsEnabledsince all broker clients (admins included) share the samebrokerClient*params.brokerClientTlsEnabledto determine if admin client should use TLSResult
Fixes #2830