Add documentation for changing load manager #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saandrews
approved these changes
Mar 30, 2017
merlimat
reviewed
Mar 30, 2017
docs/ModularLoadManager.md
Outdated
| com.yahoo.broker.loadbalance.impl.ModularLoadManagerImpl` | ||
|
|
||
| The admin tool may also be used to change back to `com.yahoo.broker.loadbalance.impl.SimpleLoadManagerImpl` | ||
| Note that the ZooKeeper node `/admin/configuration` must exist BEFORE brokers are started for this to work correctly. No newline at end of file |
Contributor
There was a problem hiding this comment.
This is actually a bug :). We should fix it instead of just documenting the behavior.
| @@ -0,0 +1,23 @@ | |||
| # Modular Load Manager | |||
Contributor
There was a problem hiding this comment.
We should also add a link to this page in docs/Documentation.md
Contributor
|
In addition to how enable the load manager, can you also cover how it works (how is the traffic reassigned, what kind of resources are monitored, etc..) |
merlimat
added
the
doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Documentation for how to switch to
ModularLoadManagerImplneeds to exist after #303 is merged.Modifications
The markdown document
docs/ModularLoadManagerImpldescribes how to switch between load managers.Result
Documentation for switching load managers will be present. The document will later be expanded to explain the architecture of
ModularLoadManagerImpl.