Removed managed-ledger-shaded artifact #4200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
May 4, 2019
Member
|
@merlimat do you want to include this in 2.4.0 or shall we move to 2.5.0? |
Contributor
|
@merlimat could renaming managed-ledger-original to managed-ledger be a BC breaking change? While I don't think many people are using managed-ledger-original, there are a few people using managed-ledger-original for their single process "integration" tests like we have in pulsar-broker. However, if they just depend on pulsar-broker they should be fine. |
Contributor
Author
|
This is not critical, moving to 2.5 |
Contributor
Author
|
@jerrypeng you're right, that's prob the reason why the test are failing, I'll take the renaming out. |
ivankelly
approved these changes
Jun 12, 2019
Contributor
ivankelly
left a comment
ivankelly
left a comment
There was a problem hiding this comment.
lgtm. The more shading we can get rid of, the better.
Contributor
|
@merlimat can you rebase this. |
Contributor
Author
|
run integration tests |
1 similar comment
Contributor
Author
|
run integration tests |
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Dec 17, 2019
* Removed managed-ledger-shaded artifact * Fixed dep artifact renaming error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Managed ledger shaded artifact was added to be used from Presto connector. Since #4045 this is not being used anymore.