-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Expose MessageId as part of Record interface #4237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run java8 tests |
7 similar comments
|
run java8 tests |
|
run java8 tests |
|
run java8 tests |
|
run java8 tests |
|
run java8 tests |
|
run java8 tests |
|
run java8 tests |
|
@srkukarni I thought we were going to do this to expose on all the attributes of the underlying message |
|
I'm not sure if there has been alignment wrt that pr. |
|
@srkukarni then lets get into agreement what we should do about this problem. I just don't want multiple ways to get the same information and cluttering the context API. We do need a simpler way to expose all the attributes of a Message so that we don't have to keep adding these one-off APIs to retrieve them. Today someone asks for MessageId, tomorrow someone might ask for getting the key of the message. I think we either allow users to consume Message as input or from the context API we can get the underlying message. I would be more in favor of the former, the one @sijie proposed |
+1 I think we should get an agreement on what directions we are taking the API to. |
|
Closed this pull request since #4341 already exposed message to record. |
<--
Contribution Checklist
Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where XYZ should be replaced by the actual issue number.
Skip Issue XYZ if there is no associated github issue for this pull request.
Skip component if you are unsure about which is the best component. E.g.
[docs] Fix typo in produce method.Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
Each pull request should address only one issue, not mix up code from multiple issues.
Each commit in the pull request has a meaningful commit message
Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation