Blocking queue #463
Merged
Blocking queue #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 19, 2017 10:19
jai1
added
area/client
doc
merlimat
reviewed
Jun 9, 2017
|
|
||
| private static final ProducerConfiguration producerConfiguration = new ProducerConfiguration().setSendTimeout(0, | ||
| TimeUnit.SECONDS); | ||
| TimeUnit.SECONDS).setBlockIfQueueFull(true).setMaxPendingMessages(1000); |
Contributor
There was a problem hiding this comment.
The producer queue size is already configurable in the broker config, right?
Contributor
Author
There was a problem hiding this comment.
Yes (set via setReplicatorQueueSize) - have made the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continuation of #422
Modifications
Changed default options in CPP and Java Client ProducerConfigurations
Fixed some test cases
Changed perf tests to block if queue is full
Restored default behavior of persistent replicator
Result
sendAsync operation will no longer block if the producer queue is full.