[Doc] Add configs for broker #5250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@fxbing could you please help review? Thank you |
fxbing
reviewed
Sep 23, 2019
| |allowAutoTopicCreationType| The type of topic that is allowed to be automatically created.(partitioned/non-partitioned) |non-partitioned| | ||
| |defaultNumPartitions| The number of partitioned topics that is allowed to be automatically created if allowAutoTopicCreationType is partitioned |1| | ||
| |allowAutoTopicCreation| Enable topic auto creation if a new producer or consumer connected |true| | ||
| |allowAutoTopicCreationType| The topic type (partitioned or non-partitioned) that is allowed to be automatically created. |non-partitioned| |
Contributor
There was a problem hiding this comment.
I have forgotten to modify the content I wrote before. Now the default type should be partitioned.
Member
Author
There was a problem hiding this comment.
Thank you, I've udpated
Contributor
|
Overall looks good to me, just left a comment. PTAL @Anonymitaet |
fxbing
approved these changes
Sep 23, 2019
Member
Author
|
run integration tests |
2 similar comments
Member
Author
|
run integration tests |
Member
Author
|
run integration tests |
merlimat
added
the
doc
Member
Author
|
run integration tests |
3 similar comments
Member
Author
|
run integration tests |
Member
Author
|
run integration tests |
Member
Author
|
run integration tests |
Jennifer88huang-zz
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5223
Add two configurations for broker:
allowAutoTopicCreationTypeallowAutoTopicCreationNumPartitions(I have confirmed with @fxbing, this property has been renamed todefaultNumPartitions)