Ensure the handling of PartitionMetadataRequest is async end-to-end #5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for fix this. seems some of related UT failed: |
Member
|
#4963 is introduced for 2.5.0. so shall this change be marked for 2.5.0? |
Contributor
Author
|
Yes, I mistakenly tagged for 2.4.2 |
codelipenghui
approved these changes
Oct 8, 2019
Contributor
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the changes in #4963, the handling of PartitionMetadataRequest is mix of sync and async operation. This is very bad because we're calling that from IO threads which are used for critical publish tasks.
Several internal methods introduced in that commit are async on the surface, though are blocking in practice.
Additionally, the logic for checking that a topic exists is unnecessarily expensive: fetching the list of topics in a namespace and then iterating through the list to compare with the current topic.
Modifications
Refactored the handling of PartitionMetadataRequest to ensure everything is end-to-end async.