Revert default topic type to non-partitioned #5308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrypeng
approved these changes
Oct 3, 2019
Member
|
The concept of partitioned/non-partitioned topic is some kind of confusing. |
Contributor
Author
No. That was a completely breaking change. It should have been caught during revision time. |
Contributor
Author
|
run integration tests |
massakam
approved these changes
Oct 4, 2019
Contributor
|
run integration tests |
aahmed-se
approved these changes
Oct 4, 2019
wolfstudy
pushed a commit
that referenced
this pull request
Nov 23, 2019
(cherry picked from commit 962973f)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The changes in #4963 did change the default topic type to be "partitioned". This is a breaking change (so far it has not been released yet).
Modifications
Change the default to "non-partitioned"