Issue 6702: add isSuperUser in AuthorizationProvider interface #6708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
requested review from
codelipenghui,
merlimat,
rdhabalia,
sijie and
tuteng
codelipenghui
approved these changes
Apr 10, 2020
Contributor
|
/pulsarbot run-failure-checks |
sijie
requested changes
Apr 10, 2020
...roker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.java
Show resolved
Hide resolved
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Apr 12, 2020
Member
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
jiazhai
added a commit
that referenced
this pull request
Jun 24, 2020
### Motivation In #6708, we change to use `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` for the dynamic check of superuser using AuthenticationDataSource. And #6428 is using old method `isSuperUser(String, ServiceConfiguration)`, This change tries to change it back. ### Modifications switch `isSuperUser(String, ServiceConfiguration)` to `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)`
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
### Motivation In apache#6708, we change to use `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` for the dynamic check of superuser using AuthenticationDataSource. And apache#6428 is using old method `isSuperUser(String, ServiceConfiguration)`, This change tries to change it back. ### Modifications switch `isSuperUser(String, ServiceConfiguration)` to `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` (cherry picked from commit 45afb56)
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 21, 2020
### Motivation In apache#6708, we change to use `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` for the dynamic check of superuser using AuthenticationDataSource. And apache#6428 is using old method `isSuperUser(String, ServiceConfiguration)`, This change tries to change it back. ### Modifications switch `isSuperUser(String, ServiceConfiguration)` to `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)`
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
### Motivation In apache#6708, we change to use `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` for the dynamic check of superuser using AuthenticationDataSource. And apache#6428 is using old method `isSuperUser(String, ServiceConfiguration)`, This change tries to change it back. ### Modifications switch `isSuperUser(String, ServiceConfiguration)` to `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)`
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
### Motivation In #6708, we change to use `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` for the dynamic check of superuser using AuthenticationDataSource. And #6428 is using old method `isSuperUser(String, ServiceConfiguration)`, This change tries to change it back. ### Modifications switch `isSuperUser(String, ServiceConfiguration)` to `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` (cherry picked from commit 45afb56)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…e#6708) Fixes apache#6702 ### Motivation Most of the methods in AuthorizationProvider take AuthenticationDataSource for authorization decision. However isSuperUser still takes the string role token. This has to be changed. ### Modifications Add needed method
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation In apache#6708, we change to use `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)` for the dynamic check of superuser using AuthenticationDataSource. And apache#6428 is using old method `isSuperUser(String, ServiceConfiguration)`, This change tries to change it back. ### Modifications switch `isSuperUser(String, ServiceConfiguration)` to `isSuperUser(String, AuthenticationDataSource, ServiceConfiguration)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6702
Motivation
Most of the methods in AuthorizationProvider take AuthenticationDataSource for authorization decision. However isSuperUser still takes the string role token. This has to be changed.
Modifications
Add needed method