Skip to content

Fix Go Functions metrics #6944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wolfstudy merged 3 commits into from
May 15, 2020
Merged

Fix Go Functions metrics #6944

wolfstudy merged 3 commits into from
May 15, 2020

Conversation

@wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented May 12, 2020 •
edited
Loading

Signed-off-by: xiaolong.ran rxl@apache.org

Modifications

@wolfstudy
Fix go functions metrics
b91045e 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy wolfstudy self-assigned this May 12, 2020
@wolfstudy wolfstudy added this to the 2.6.0 milestone May 12, 2020
@wolfstudy
fix a little
56c5955 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Copy link
Member Author

wolfstudy commented May 12, 2020

@devinbost Can you help review these changes?

@wolfstudy
fix ci error
41ccb61 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Copy link
Member Author

wolfstudy commented May 12, 2020

/pulsarbot run-failure-checks

1 similar comment
@wolfstudy
Copy link
Member Author

wolfstudy commented May 13, 2020

/pulsarbot run-failure-checks

@devinbost
Copy link
Contributor

devinbost commented May 13, 2020

@wolfstudy Thanks for picking up this task. These changes all look good to me.

@wolfstudy
Copy link
Member Author

wolfstudy commented May 13, 2020

@wolfstudy Thanks for picking up this task. These changes all look good to me.

Thanks your feedback

@wolfstudy
Copy link
Member Author

wolfstudy commented May 13, 2020

/pulsarbot run-failure-checks

@wolfstudy
Copy link
Member Author

wolfstudy commented May 13, 2020 

[INFO] Running org.apache.pulsar.broker.service.TopicTerminationTest
[ERROR] Tests run: 20, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 44.428 s <<< FAILURE! - in org.apache.pulsar.broker.service.ReplicatorTest
[ERROR] testUpdateGlobalTopicPartition(org.apache.pulsar.broker.service.ReplicatorTest)  Time elapsed: 0.017 s  <<< FAILURE!
org.apache.pulsar.client.admin.PulsarAdminException$ConflictException: Namespace already exists
	at org.apache.pulsar.client.admin.internal.BaseResource.getApiException(BaseResource.java:223)
	at org.apache.pulsar.client.admin.internal.BaseResource$1.failed(BaseResource.java:133)
	at org.glassfish.jersey.client.JerseyInvocation$4.failed(JerseyInvocation.java:1030)
	at org.glassfish.jersey.client.JerseyInvocation$4.completed(JerseyInvocation.java:1017)
	at org.glassfish.jersey.client.ClientRuntime.processResponse(ClientRuntime.java:227)
	at org.glassfish.jersey.client.ClientRuntime.access$200(ClientRuntime.java:85)
	at org.glassfish.jersey.client.ClientRuntime$2.lambda$response$0(ClientRuntime.java:178)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:272)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:268)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:316)

@wolfstudy
Copy link
Member Author

wolfstudy commented May 14, 2020

/pulsarbot run-failure-checks

@wolfstudy
Copy link
Member Author

wolfstudy commented May 14, 2020 

[INFO] Running org.apache.pulsar.broker.admin.v1.V1_AdminApiTest
[ERROR] Tests run: 46, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 262.601 s <<< FAILURE! - in org.apache.pulsar.broker.admin.v1.V1_AdminApiTest
[ERROR] partitionedTopics(org.apache.pulsar.broker.admin.v1.V1_AdminApiTest)  Time elapsed: 60.737 s  <<< FAILURE!
org.apache.pulsar.client.admin.PulsarAdminException$TimeoutException: java.util.concurrent.TimeoutException
	at org.apache.pulsar.client.admin.internal.TopicsImpl.getPartitionedTopicMetadata(TopicsImpl.java:430)
	at org.apache.pulsar.broker.admin.v1.V1_AdminApiTest.partitionedTopics(V1_AdminApiTest.java:906)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)

@wolfstudy
Copy link
Member Author

wolfstudy commented May 14, 2020

/pulsarbot run-failure-checks

@wolfstudy wolfstudy merged commit fdeaa30 into apache:master May 15, 2020
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request May 27, 2020
@wolfstudy @Huanli-Meng
Fix Go Functions metrics (apache#6944)
9ce7a60 
* Fix go functions metrics

Signed-off-by: xiaolong.ran <rxl@apache.org>

* fix a little

Signed-off-by: xiaolong.ran <rxl@apache.org>

* fix ci error

Signed-off-by: xiaolong.ran <rxl@apache.org>
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@wolfstudy @huangdx0726
Fix Go Functions metrics (apache#6944)
8abb595 
* Fix go functions metrics

Signed-off-by: xiaolong.ran <rxl@apache.org>

* fix a little

Signed-off-by: xiaolong.ran <rxl@apache.org>

* fix ci error

Signed-off-by: xiaolong.ran <rxl@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiazhai jiazhai jiazhai approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@sijie sijie Awaiting requested review from sijie

Assignees

@wolfstudy wolfstudy

Labels

area/function

Projects

None yet

Milestone

2.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wolfstudy @devinbost @jiazhai @codelipenghui