Skip to content

Conversation

@srkukarni
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

The Classloading and Reflection helpers are useful not just in functions but also in io. This pr moves them to pulsar.common

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@srkukarni srkukarni added this to the 2.6.0 milestone May 29, 2020
@srkukarni srkukarni requested review from jerrypeng, merlimat and sijie May 29, 2020 21:48
@srkukarni srkukarni self-assigned this May 29, 2020
Sanjeev Kulkarni added 2 commits May 29, 2020 16:49
@srkukarni srkukarni merged commit e451be3 into apache:master May 30, 2020
@srkukarni srkukarni deleted the move_reflections branch May 30, 2020 05:24
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
…#7103)

* Moved ClassLoading and Reflections Helper functions to common

* Fix tests

* Fix test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
…#7103)

* Moved ClassLoading and Reflections Helper functions to common

* Fix tests

* Fix test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 12, 2020
…#7103)

* Moved ClassLoading and Reflections Helper functions to common

* Fix tests

* Fix test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
merlimat pushed a commit to merlimat/pulsar that referenced this pull request Jun 30, 2020
…#7103)

* Moved ClassLoading and Reflections Helper functions to common

* Fix tests

* Fix test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
…#7103)

* Moved ClassLoading and Reflections Helper functions to common

* Fix tests

* Fix test

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants