Only close active consumer for Failover subscription when seek(). #7141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
jiazhai,
massakam,
merlimat,
rdhabalia and
sijie
and removed request for
massakam and
merlimat
codelipenghui
added
the
type/enhancement
Contributor
|
/pulsarbot run-failure-checks |
codelipenghui
force-pushed
the
close_consumer_seek
branch
from
9d08e72 to
b709b23
Compare
jiazhai
approved these changes
Jun 3, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
1 task
Contributor
Author
|
/pulsarbot run-failure-checks |
This was referenced Jun 3, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ache#7141) Related to apache#5278 ### Motivation Only close active consumer for Failover subscription when seek(). ### Verifying this change Unit tests added ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): ( no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation - Does this pull request introduce a new feature? (no)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5278
Motivation
Only close active consumer for Failover subscription when seek().
Verifying this change
Unit tests added
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation