Allow function rebalance to be run periodically #7449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkukarni
reviewed
Jul 4, 2020
conf/functions_worker.yml
Outdated
| failureCheckFreqMs: 30000 | ||
| rescheduleTimeoutMs: 60000 | ||
| # frequency at which to check if cluster needs rebalancing (15min default interval) | ||
| rebalanceCheckFreqSec: 900 |
Contributor
There was a problem hiding this comment.
Do we want to turn it on by default? Also is 15 min too frequent
Contributor
Author
There was a problem hiding this comment.
Set it 1 hour? Is there any harm to enable by default?
Member
|
@jerrypeng can we update the Motivation and Modifications? |
srkukarni
reviewed
Jul 6, 2020
srkukarni
approved these changes
Jul 6, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After a rebalance mechanism was implement for pulsar functions in:
#7388
it is only natural to add the functionality for the rebalance to be triggered periodically.
Modifications
Allow rebalance to be triggered on a user defined frequency