[Issue 7502] Fixed some compilation issues when enabling -Wall. #7503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Jul 10, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
smazurov
reviewed
Aug 28, 2020
| requestIdGenerator_(0), | ||
| closingError(ResultOk) { | ||
| std::unique_ptr<LoggerFactory> loggerFactory = clientConfiguration_.impl_->takeLogger(); | ||
| if (!logger) { |
Contributor
There was a problem hiding this comment.
This breaks all custom logging implementations. loggerFactory is now set to either SimpleLoggerFactory or Log4CxxLoggerFactory even if client configuration sets one.
1 task
jiazhai
pushed a commit
that referenced
this pull request
Sep 10, 2020
#7932) ### Motivation I want to use custom logging factory in cpp client ### Modifications #7132 broke custom logger config option. It then was identified in #7503 (and #7502) but not fixed. This PR actually fixes it by checking the right variable name. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation This PR does not introduce any new functionality, but it fixes existing functionality that presumably is already documented. * Fix for not respecting custom LoggerFactory client config * Add Custom Logger Factory Test * revert threads used by make in docker-build Co-authored-by: Stepan Mazurov <smazurov@quantummetric.com>
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
apache#7932) ### Motivation I want to use custom logging factory in cpp client ### Modifications apache#7132 broke custom logger config option. It then was identified in apache#7503 (and apache#7502) but not fixed. This PR actually fixes it by checking the right variable name. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation This PR does not introduce any new functionality, but it fixes existing functionality that presumably is already documented. * Fix for not respecting custom LoggerFactory client config * Add Custom Logger Factory Test * revert threads used by make in docker-build Co-authored-by: Stepan Mazurov <smazurov@quantummetric.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7502
The compilation problem described in #7502 is resolved.