Add configuration to enable throttling for non-backlog consumers #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
the
type/enhancement
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in #634 : Right now, broker doesn't apply message-throttling for the consumers which are already caught-up and don't have backlog because these consumers directly reads message from the cache and doesn't make bookkeeper read. But in some cases, broker wants to throttle overall dispatch rate to control n/w bandwidth as well. So, it requires to add configuration which can enable throttling for non-backlog consumers as well.
Modifications
Add dynamic-configuration to enable throttling for non-backlog consumers as well.
Result
Broker has capability to configure throttling for already caught up consumers.