Skip to content

[Pulsar-client-cli] fix some params on consumer broken by #4400 (regex, initialSouscriptionPosition) #7795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sijie merged 1 commit into from
Aug 11, 2020
Merged

[Pulsar-client-cli] fix some params on consumer broken by #4400 (regex, initialSouscriptionPosition) #7795

sijie merged 1 commit into from
Aug 11, 2020

Conversation

@Mefl
Copy link
Contributor

@Mefl Mefl commented Aug 11, 2020 •
edited
Loading

Motivation

The PR #4400 introduced new params on the pulsar-client consume command but it broked some old ones.

Modifications

This PR fixes this problem to restore the good param behavior.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options:no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? no

@Mefl Mefl changed the title [Pulsar-client] fix some params on consumer broken by #4400 (regex, initialSouscriptionPosition) [Pulsar-client-cli] fix some params on consumer broken by #4400 (regex, initialSouscriptionPosition) Aug 11, 2020
@codelipenghui codelipenghui added release/2.6.2 type/bug The PR fixed a bug or issue reported a bug labels Aug 11, 2020
@codelipenghui codelipenghui added this to the 2.7.0 milestone Aug 11, 2020
@sijie sijie merged commit a4a12d1 into apache:master Aug 11, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@Mefl @huangdx0726
Fix the params broken by PR apache#4400 (apache#7795)
9ef5d5a 
### Motivation
The PR apache#4400 introduced new params on the pulsar-client consume command but it broked some old ones.

### Modifications

This PR fixes this problem to restore the good param behavior.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@Mefl
Fix the params broken by PR apache#4400 (apache#7795)
63fa033 
### Motivation
The PR apache#4400 introduced new params on the pulsar-client consume command but it broked some old ones.

### Modifications

This PR fixes this problem to restore the good param behavior.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@Mefl
Fix the params broken by PR apache#4400 (apache#7795)
ae6b426 
### Motivation
The PR apache#4400 introduced new params on the pulsar-client consume command but it broked some old ones.

### Modifications

This PR fixes this problem to restore the good param behavior.
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@Mefl
Fix the params broken by PR apache#4400 (apache#7795)
bb4d826 
### Motivation
The PR apache#4400 introduced new params on the pulsar-client consume command but it broked some old ones.

### Modifications

This PR fixes this problem to restore the good param behavior.
wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
@Mefl @wolfstudy
Fix the params broken by PR #4400 (#7795)
719f524 
### Motivation
The PR #4400 introduced new params on the pulsar-client consume command but it broked some old ones.

### Modifications

This PR fixes this problem to restore the good param behavior.

(cherry picked from commit a4a12d1)
@aloyszhang aloyszhang mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jiazhai jiazhai Awaiting requested review from jiazhai

@merlimat merlimat Awaiting requested review from merlimat

@sijie sijie Awaiting requested review from sijie

Assignees

@Mefl Mefl

Labels

release/2.6.2 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Mefl @codelipenghui @sijie