Skip to content

Conversation

@rmn36
Copy link

@rmn36 rmn36 commented Aug 20, 2020

Fixes #7846

Motivation

Given a wildcard in a tenant or namespace I would expect the code to look up all tenants/namespaces that match and then lookup all topics to subscribe to.

Verifying this change

  • Updated PatternMultiTopicsConsumerImplTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@jiazhai jiazhai added doc-required Your PR changes impact docs and you will update later. area/client labels Aug 20, 2020
@sijie sijie added this to the 2.7.0 milestone Aug 24, 2020
@sijie sijie added the type/feature The PR added a new feature or issue requested a new feature label Aug 24, 2020
@jiazhai
Copy link
Member

jiazhai commented Sep 9, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented Sep 13, 2020

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented Sep 13, 2020

@rmn36 Seems some of the error in ci is related to this change.
e.g. cpp ci test:

/pulsar/pulsar-client-cpp/lib/Commands.cc: In static member function 'static std::__cxx11::string pulsar::Commands::messageType(pulsar::proto::BaseCommand_Type)':
/pulsar/pulsar-client-cpp/lib/Commands.cc:464:12: error: enumeration value 'BaseCommand_Type_GET_NAMESPACES_BY_REGEX' not handled in switch [-Werror=switch]
     switch (type) {
            ^
/pulsar/pulsar-client-cpp/lib/Commands.cc:464:12: error: enumeration value 'BaseCommand_Type_GET_NAMESPACES_BY_REGEX_RESPONSE' not handled in switch [-Werror=switch]
[  9%] Building CXX object lib/CMakeFiles/pulsarStatic.dir/ClientConnection.cc.o
[  9%] Building CXX object lib/CMakeFiles/pulsarStatic.dir/TopicName.cc.o

@jiazhai
Copy link
Member

jiazhai commented Oct 27, 2020

@rmn36 Would you please help rebase the code with master, and get the ci fixed?

@codelipenghui
Copy link
Contributor

@rmn36 Would you please help resolve the conflicts?

@codelipenghui
Copy link
Contributor

move to 2.8.0 first

@codelipenghui codelipenghui modified the milestones: 2.7.0, 2.8.0 Nov 17, 2020
@Anonymitaet
Copy link
Member

Anonymitaet commented Mar 9, 2021

@rmn36 thanks for your work.

  1. Any progress for this PR?
  2. Could you please help add docs accordingly? Thanks

@Anonymitaet
Copy link
Member

@rmn36 thanks for your work.

  1. Any progress for this PR?
  2. Could you please help add docs accordingly? Thanks

@codelipenghui codelipenghui modified the milestones: 2.8.0, 2.9.0 May 19, 2021
@Anonymitaet
Copy link
Member

Hi @rmn36 any progress for the code and doc? thanks

@ccwxl
Copy link

ccwxl commented Sep 18, 2021

Is there any update? We really need this feature.

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@TonyYANOqton
Copy link

Hi, anybody knows when this feature is expected to be released? We really need this feature too.

@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Jul 26, 2022
@tisonkun
Copy link
Member

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.

@tisonkun tisonkun closed this Dec 10, 2022
@tisonkun
Copy link
Member

@TonyYANOqton This seems a new feature that can require a PIP to proceed. I move the original issue to the discussion forum #18862 since we don't have a consensus on whether this is the right way yet.

As you can see, this patch conflicts a lot of files and it requires significant effort to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client doc-required Your PR changes impact docs and you will update later. lifecycle/stale type/feature The PR added a new feature or issue requested a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-Topic subscription across tenant and namespace using regex in Java client throws IllegalArgumentException

10 participants