Improve protobuf and grpc dependency management #8371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Oct 26, 2020
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
- Use protobuf-bom to manage protobuf library versions - make protoc3.version match protobuf3.version - there should be no reason that these would be different - make grpc's protoc-gen-grpc-java.version match grpc.version - there should be no reason that there would be different
lhotari
force-pushed
the
lh-use-protobuf-bom
branch
from
e556151 to
538b1bf
Compare
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 27, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
### Motivation For managing protobuf libraries there is a maven bom file available for protobuf. The benefit of using this is that it can be imported to the project's pom.xml dependency management to make sure that the versions of the various protobuf libraries are aligned and use the same version. Besides starting to use protobuf-bom, it was noticed that there are separate settings for protobuf protoc version (`protoc3.version`) and the protoc grpc plugin versions (`protoc-gen-grpc-java.version`). These versions should match the protobuf and grpc versions. The PR also covers an improvement for that. One motivation of this PR is to prepare for the grpc upgrade that was attempted by apache#8351 , but reverted. Before doing the grpc upgrade, it would be useful to improve the protobuf & grpc dependency management provided by this PR. ### Modifications * Use protobuf-bom to manage protobuf library versions * make `protoc3.version` match `protobuf3.version` * there should be no reason that these would be different * make grpc's `protoc-gen-grpc-java.version` match `grpc.version` * there should be no reason that there would be different
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation For managing protobuf libraries there is a maven bom file available for protobuf. The benefit of using this is that it can be imported to the project's pom.xml dependency management to make sure that the versions of the various protobuf libraries are aligned and use the same version. Besides starting to use protobuf-bom, it was noticed that there are separate settings for protobuf protoc version (`protoc3.version`) and the protoc grpc plugin versions (`protoc-gen-grpc-java.version`). These versions should match the protobuf and grpc versions. The PR also covers an improvement for that. One motivation of this PR is to prepare for the grpc upgrade that was attempted by apache#8351 , but reverted. Before doing the grpc upgrade, it would be useful to improve the protobuf & grpc dependency management provided by this PR. ### Modifications * Use protobuf-bom to manage protobuf library versions * make `protoc3.version` match `protobuf3.version` * there should be no reason that these would be different * make grpc's `protoc-gen-grpc-java.version` match `grpc.version` * there should be no reason that there would be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For managing protobuf libraries there is a maven bom file available for protobuf. The benefit of using this is that it can be imported to the project's pom.xml dependency management to make sure that the versions of the various protobuf libraries are aligned and use the same version.
Besides starting to use protobuf-bom, it was noticed that there are separate settings for protobuf protoc version (
protoc3.version) and the protoc grpc plugin versions (protoc-gen-grpc-java.version). These versions should match the protobuf and grpc versions. The PR also covers an improvement for that.One motivation of this PR is to prepare for the grpc upgrade that was attempted by #8351 , but reverted. Before doing the grpc upgrade, it would be useful to improve the protobuf & grpc dependency management provided by this PR.
Modifications
protoc3.versionmatchprotobuf3.versionprotoc-gen-grpc-java.versionmatchgrpc.version