Skip to content

Update grpc to 1.31.0 #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aahmed-se wants to merge 1 commit into from
Closed

Update grpc to 1.31.0 #8403

aahmed-se wants to merge 1 commit into from

Conversation

@aahmed-se
Copy link
Contributor

@aahmed-se aahmed-se commented Oct 29, 2020

No description provided.

@aahmed-se aahmed-se self-assigned this Oct 29, 2020
@aahmed-se aahmed-se force-pushed the grpc1 branch 4 times, most recently from 4a9b67e to 49e3631 Compare October 29, 2020 04:51
@aahmed-se aahmed-se changed the title Update grpc to 1.33.0 Update grpc to 1.31.0 Oct 29, 2020
@aahmed-se aahmed-se force-pushed the grpc1 branch 4 times, most recently from a59445e to 8dcbd79 Compare October 30, 2020 01:34
@aahmed-se aahmed-se closed this Jan 9, 2021
@aahmed-se aahmed-se deleted the grpc1 branch January 23, 2021 09:25
@lhotari
Copy link
Member

lhotari commented Jan 30, 2021

@aahmed-se @pkumar-singh @srkukarni @dlg99 It seems that this PR was never merged. Was that intentional?

We are also facing the grpc deadlock issue described in PR #8351 (that PR had to be reverted at that time because of multiple issues described in the comment history) and it would be important to get the problem fixed asap.

@aahmed-se Were there some obstacles in upgrading grpc to 1.31.0 ?

@aahmed-se
Copy link
Contributor Author

aahmed-se commented Jan 30, 2021

THis requires some changes in bookkeeper first and the reference version in pulsar be upgraded.

@lhotari
Copy link
Member

lhotari commented Jan 30, 2021

@aahmed-se Thanks for explaining. Would you mind adding a reference to the changes that are required? What is the status of those changes?

@aahmed-se
Copy link
Contributor Author

aahmed-se commented Jan 30, 2021

The changes have been made internally in our bookkeeper they are quite substantial.
I don't know the current plans on when they can pushed upstream. It depends on when there is downtime in work.

@eolivelli
Copy link
Contributor

eolivelli commented Jan 30, 2021

@diegosalvi @aluccaroni which GRPC version do you have in EmailSuccess stack ? IIRC we had upgraded to latest version recently

@diegosalvi
Copy link
Contributor

diegosalvi commented Feb 1, 2021

@eolivelli Thank you. No, actually it needs to be upgraded. Next release cycle

@dlg99
Copy link
Contributor

dlg99 commented Feb 3, 2021

@aahmed-se @lhotari can you take a look at apache/bookkeeper#2582 - I tried to upgrade grpc for bookkeeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srkukarni srkukarni srkukarni approved these changes

+1 more reviewer

@pkumar-singh pkumar-singh pkumar-singh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aahmed-se aahmed-se

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aahmed-se @lhotari @eolivelli @diegosalvi @dlg99 @srkukarni @pkumar-singh