[Transaction] Support produce batch transaction messages #8415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Oct 31, 2020
Contributor
|
/pulsarbot run-failure-checks |
50 tasks
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
### Motivation Currently, Pulsar only supports produce transaction messages in no batch mode. ### Modifications Add transaction id in the batch message container, if the newly added message has a different transaction id with the container, it will be added in the next batch. ### Verifying this change add a new unit test. **org.apache.pulsar.client.impl.TransactionEndToEndTest#batchProduceCommitTest**
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation Currently, Pulsar only supports produce transaction messages in no batch mode. ### Modifications Add transaction id in the batch message container, if the newly added message has a different transaction id with the container, it will be added in the next batch. ### Verifying this change add a new unit test. **org.apache.pulsar.client.impl.TransactionEndToEndTest#batchProduceCommitTest**
This was referenced Nov 21, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, Pulsar only supports produce transaction messages in no batch mode.
Modifications
Add transaction id in the batch message container, if the newly added message has a different transaction id with the container, it will be added in the next batch.
Verifying this change
add a new unit test.
org.apache.pulsar.client.impl.TransactionEndToEndTest#batchProduceCommitTest
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes