Fix the residual of inactive partitioned-topic cleaning #8442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
requested changes
Nov 5, 2020
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
315157973
force-pushed
the
inactive
branch
3 times, most recently
from
3514654 to
33d4412
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
…ersistent/PersistentTopic.java Co-authored-by: lipenghui <penghui@apache.org>
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 11, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
Fixes apache#8441 ### Motivation When `inactivityMonitor clean` inactive partitioned topic, the node in ZK is not deleted ### Modifications add `deleteZkNode` ### Verifying this change InactiveTopicDeleteTest#testDeleteAndCleanZkNode
codelipenghui
pushed a commit
that referenced
this pull request
Dec 15, 2021
## Motivation This is a fix about non-persistent partitioned topics related to #8442. ## Modification - Add tryToDeletePartitionedMetadata to clean up the metadata info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8441
Motivation
When
inactivityMonitor cleaninactive partitioned topic, the node in ZK is not deletedModifications
add
deleteZkNodeVerifying this change
InactiveTopicDeleteTest#testDeleteAndCleanZkNode