Skip to content

Support key base for python function #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 12 commits into from
Nov 22, 2020
Merged

Support key base for python function #8540

codelipenghui merged 12 commits into from
Nov 22, 2020

Conversation

@wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented Nov 12, 2020 •
edited
Loading

Motivation

The changing base on #8523

Modifications

Support key_base for python function

@wolfstudy
Support key_based batch builder for functions and sources
efa2473 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Avoid using * in import
9b93663 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Merge branch 'master' into xiaolong/support-key-base-in-function
acb29ec
@wolfstudy
fix ci error
ac089ea 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Support key_based feature for python function
34a8a6a 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy wolfstudy added this to the 2.7.0 milestone Nov 12, 2020
@wolfstudy wolfstudy self-assigned this Nov 12, 2020
@wolfstudy wolfstudy mentioned this pull request Nov 12, 2020
Closed
@wolfstudy wolfstudy requested a review from hangc0276 November 17, 2020 01:16
@codelipenghui
Copy link
Contributor

codelipenghui commented Nov 17, 2020

/pulsarbot run-failure-checks

@sijie
Copy link
Member

sijie commented Nov 18, 2020

@wolfstudy the change looks good. But I think we introduced a feature to support end-to-end encryption in Pulsar Function in #8432. I think we need to include this support for python functions as well. In this change, there is code generated for crypto reader. Can you create an issue to follow up to add this support?

@wolfstudy
Copy link
Member Author

wolfstudy commented Nov 18, 2020

@wolfstudy the change looks good. But I think we introduced a feature to support end-to-end encryption in Pulsar Function in #8432. I think we need to include this support for python functions as well. In this change, there is code generated for crypto reader. Can you create an issue to follow up to add this support?

Sure, will process it.

@wolfstudy
fix ci test error
07a9293 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
update proto file
d142ed0 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@codelipenghui
Copy link
Contributor

codelipenghui commented Nov 19, 2020

/pulsarbot run-failure-checks

sijie
sijie reviewed Nov 19, 2020
View reviewed changes
...gration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java Outdated
import org.apache.pulsar.client.api.Schema;
import org.apache.pulsar.client.api.SubscriptionInitialPosition;
import org.apache.pulsar.client.api.SubscriptionType;
import org.apache.pulsar.client.api.*;
Copy link
Member

@sijie sijie Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid using wildcard import?

Copy link
Member Author

@wolfstudy wolfstudy Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will fix it.

@wolfstudy
fix commets
ebfd546 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@codelipenghui
Copy link
Contributor

codelipenghui commented Nov 20, 2020

/pulsarbot run-failure-checks

@wolfstudy
test ci error
e9ca083 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
fix ci error
1ae7762 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
Merge branch 'master' into xiaolong/support-key-base-for-python-function
7e6f3e1
@codelipenghui codelipenghui merged commit 334dffd into apache:master Nov 22, 2020
@lhotari lhotari mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie left review comments

@codelipenghui codelipenghui codelipenghui approved these changes

@srkukarni srkukarni Awaiting requested review from srkukarni

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

@hangc0276 hangc0276 Awaiting requested review from hangc0276

Assignees

@wolfstudy wolfstudy

Labels

area/function

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wolfstudy @codelipenghui @sijie