Disable maven's http connection pooling to mitigate "connection reset… #8921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" issues - previously the http connection pooling timeout was reduced to 25 seconds in PR apache#8386. However the issue has persisted. The mitigation used in other projects is to disable maven's http connection pooling completely. The solution is proposed here: - actions/runner-images#1499 (comment)
lhotari
force-pushed
the
lh-disable-maven-http-connection-pool
branch
from
4b7530d to
d27d6ac
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
sijie
approved these changes
Dec 13, 2020
bjhargrave
added a commit
to bndtools/bnd
that referenced
this pull request
Feb 16, 2021
We set retries to 3 and disable maven connection pooling which sometimes interacts badly with the Azure backend of GitHub Actions vms. See apache/pulsar#8921 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Apr 28, 2023
- Maven http connection pooling was originally disabled with apache#8921 - Maven is switching to "Maven Resolver" ("aether") in newer versions instead of using Wagon. - Disable Maven http connection pooling also for aether - Set request timeout to 60000ms also for aether
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #8386 configured the http connection pooling timeout to 25 seconds.
However the "connection reset" issue with maven dependency downloads has persisted.
he mitigation used in other projects is to disable maven's http connection pooling completely.
The solution is proposed here:
Modifications
Disable maven's http connection pool by passing
-Dhttp.keepAlive=false -Dmaven.wagon.http.pool=falseinMAVEN_OPTSenvironment variable.