Fix UnAckedMessageTracker timeout send redelivery messages

[saosir]

Motivation

pulsar client UnAckedMessageTracker wait one more tickDurationInMs to send redelivery message at timeout

Modifications

Fix the formula for calculating the size of timePartitions through the parameters ackTimeoutMillis and tickDurationInMs

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (no)
• The schema: (no)
• The default values of configurations: (no)
• The wire protocol: (no)
• The rest endpoints: (no)
• The admin cli options: (no)
• Anything that affects deployment: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[sijie]

@BewareMyPower Can you review this pull request?

[saosir]

see #9072 (comment)

[sijie]

@saosir Can you rebase to the latest master? There are recent changes to fix the broken master.

[BewareMyPower]

/pulsarbot run-failure-checks

[saosir]

/pulsarbot run-failure-checks

[BewareMyPower]

/pulsarbot run-failure-checks

[eolivelli]

What about extracting the computation to a static method and create unit tests?
Even of it is a one line change it is not so obvious that the fix works

[saosir]

Why the CI always fail? @BewareMyPower

[BewareMyPower]

@saosir Maybe you can try to rebase to latest master because sometimes some flaky tests might be fixed. (I also noticed this PR's test failed for many times...

[BewareMyPower]

/pulsarbot run-failure-checks

[saosir]

/pulsarbot run-failure-checks

[sijie]

/pulsarbot run-failure-checks

[sijie]

/pulsarbot run-failure-checks

[sijie]

/pulsarbot run-failure-checks

[zymap]

/pulsarbot run-failure-checks

[saosir]

/pulsarbot run-failure-checks

[zymap]

Failure tests

[INFO] 
Error:  Failures: 
Error:  org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedNormalTopic(org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest)
[INFO]   Run 1: PASS
Error:    Run 2: PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedNormalTopic:148 expected [5] but found [10]
[INFO] 
Error:  org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedPartitionedTopic(org.apache.pulsar.client.impl.PerMessageUnAcknowledgedRedeliveryTest)
[INFO]   Run 1: PASS
Error:    Run 2: PerMessageUnAcknowledgedRedeliveryTest.testSharedAckedPartitionedTopic:494 expected [5] but found [10]
[INFO] 
[INFO] 
Error:  Tests run: 229, Failures: 2, Errors: 0, Skipped: 0

[zymap]

@saosir Looks like the CI failed by this change. Please take a look. Thank you.

I will push this to the next release.

[saosir]

@saosir Looks like the CI failed by this change. Please take a look. Thank you.

I will push this to the next release.

OK, I am looking for time to fix this problem. Before I thought that modifying two lines of code would not have any impact on
test cases, but this caused some cases to fail.

[saosir]

see #3118
@codelipenghui pulsar client UnAckedMessageTracker wait one more tickDurationInMs to send redelivery message at timeout. Is it expected？The test case is also designed like this.

pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/PerMessageUnAcknowledgedRedeliveryTest.java

Lines 480 to 497 in 796c011

	assertEquals(size, 10);
	Thread.sleep(ackTimeOutMillis);
	// 10. Receiver receives redelivered messages
	message = consumer.receive();
	int redelivered = 0;
	while (message != null) {
	redelivered++;
	String data = new String(message.getData());
	log.info("Consumer received : " + data);
	consumer.acknowledge(message);
	message = consumer.receive(100, TimeUnit.MILLISECONDS);
	}
	assertEquals(redelivered, 5);
	size = getUnackedMessagesCountInPartitionedConsumer(consumer);
	log.info(key + " Unacked Message Tracker size is " + size);
	assertEquals(size, 5);

How about just close this pull request?