-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix typo in wokerserviceloader #9169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Jan 11, 2021
Member
|
/pulsarbot run-failure-checks |
3 similar comments
Member
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jan 13, 2021
Contributor
pkumar-singh
pushed a commit
to pkumar-singh/pulsar
that referenced
this pull request
Jan 27, 2021
### Motivation Fix typo in WorkerServiceLoader.java to avoid error while project build under java 15: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project pulsar-functions-worker: Compilation failure [ERROR] /Users/jia/ws/code/pulsar/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/WorkerServiceLoader.java:[23,38] package com.sun.corba.se.pept.protocol does not exist ``` ### Modifications Fix to the right type. ### Verifying this change build passed
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
### Motivation Fix typo in WorkerServiceLoader.java to avoid error while project build under java 15: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project pulsar-functions-worker: Compilation failure [ERROR] /Users/jia/ws/code/pulsar/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/WorkerServiceLoader.java:[23,38] package com.sun.corba.se.pept.protocol does not exist ``` ### Modifications Fix to the right type. ### Verifying this change build passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/function
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix typo in WorkerServiceLoader.java to avoid error while project build under java 15:
Modifications
Fix to the right type.
Verifying this change
build passed