-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix the set-project-version scripts #9198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- *Motivation* We introduce a new way to handle the proto and remove the 'protobuf-shaded/pom.xml' in the PR apache#9046. We need to remove the set version in the scripts.
codelipenghui
approved these changes
Jan 13, 2021
Contributor
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Jan 13, 2021
sijie
approved these changes
Jan 13, 2021
Member
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
|
/pulsarbot run-failure-checks |
Member
|
/pulsarbot run-failure-checks |
315157973
approved these changes
Jan 13, 2021
Member
Author
|
Flaky test: |
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
Failed test: |
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jan 13, 2021
merlimat
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We introduce a new way to handle the proto and remove the
'protobuf-shaded/pom.xml' in the PR #9046.
We need to remove the set version in the scripts.