Fixed hasMessageAvailable() with empty topic #9316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
codelipenghui,
jerrypeng,
jiazhai,
rdhabalia and
sijie
jerrypeng
approved these changes
Jan 26, 2021
sijie
approved these changes
Jan 26, 2021
sijie
added
area/client
java
type/bug
wolfstudy
approved these changes
Jan 28, 2021
Member
|
/pulsarbot run-failure-checks |
4 similar comments
Contributor
|
/pulsarbot run-failure-checks |
Contributor
|
/pulsarbot run-failure-checks |
Contributor
|
/pulsarbot run-failure-checks |
Contributor
|
/pulsarbot run-failure-checks |
Contributor
Author
|
Fixed in #9652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the topic is empty, the
Reader.hasMessageAvailable()can return incorrect results if the reader is started on latest. The main issue is that we are not associating the last message in topic with the "real" position of the reader.