Skip to content

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Feb 4, 2021

This reverts commit #8422: a1107ad.

Motivation

As explained in #9470, the changes in this commit are now making the SQL integration tests to fail and blocking all changes to master. Reverting now to unblock, please re-submit the PR once the test is fixed.

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Feb 4, 2021
@merlimat merlimat added this to the 2.8.0 milestone Feb 4, 2021
@merlimat merlimat added area/build and removed type/bug The PR fixed a bug or issue reported a bug labels Feb 4, 2021
@codelipenghui
Copy link
Contributor

@merlimat @jerrypeng The master broken issue is fixed by #9472 I think, we have verified on the local environment. If the master issue can be fixed, I think we don't need to revert it.

@merlimat merlimat closed this Feb 4, 2021
@merlimat merlimat deleted the fix-master branch February 4, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants