[pulsar-broker] topic resources use metadata-store api #9485
Conversation
rdhabalia
force-pushed
the
zk_rest_topic
branch
5 times, most recently
from
7040951 to
be4b114
Compare
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
LGTM. Should this get rebased on master?
rdhabalia
force-pushed
the
zk_rest_topic
branch
2 times, most recently
from
3d56725 to
ec31a9a
Compare
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I really like how much we are making core Pulsar code much more simpler!
Overall it looks good to me, I left some minor comments
| } | ||
| }); | ||
| } else if (ex.getCause() instanceof BadVersionException) { | ||
| log.warn("[{}] Fail to create topic partition {} with concurrent modification, retry now.", |
There was a problem hiding this comment.
Is this message still valid ?
It looks like we are completing the operation with success
There was a problem hiding this comment.
yes, good catch. it's related to #9501 , I will fix log.
| log.error("Failed to delete partitioned topic.", e); | ||
| asyncResponse.resume(new RestException(e)); | ||
| try { | ||
| namespaceResources().getPartitionedTopicResouces().deleteAsync(path).thenAccept(r2 -> { |
There was a problem hiding this comment.
is this a typo?
getPartitionedTopicResouces -> getPartitionedTopicResources
| } | ||
|
|
||
| @AfterClass | ||
| @AfterMethod |
There was a problem hiding this comment.
don't forget "alwaysRun = true", otherwise resources won't be disposed in case of test failure
| try { | ||
| bookie.shutdown(); | ||
| } catch (Exception e) { | ||
| LOG.warn("failed to shutdown bookie", e); |
There was a problem hiding this comment.
in case of InterruptedException we should set Thread.currentThead().interrupt();
There was a problem hiding this comment.
it doesn't throw InterruptedException but in some cases it was throwing other runtime exception in test, while closing the resources. So, it helps test to clean other resources by handling this failure.
rdhabalia
force-pushed
the
zk_rest_topic
branch
from
d62e563 to
18671d7
Compare
[pulsar-broker] MockZK: Handle zk-children watch notification fix test fix sync function initialization fix tests fix zk-create add timeout
rdhabalia
force-pushed
the
zk_rest_topic
branch
from
18671d7 to
0dd96b0
Compare
3 participants
Motivation
This PR is on top of #9351, with this change, topuc-resources will start using metadata-api and remove zk-dependency.