Skip to content

Conversation

@bithavoc
Copy link
Contributor

@bithavoc bithavoc commented Feb 10, 2021

Fixes #4044 and #3367, completes streamnative/pulsar/issues/290

Motivation

When you google "docker compose pulsar", the first results points to docker-compose/standalone-dashboard/docker-compose.yml which works for the most part if you use CLI commands such as pulsar-admin, but the dashboard never shows any tenant, topics, etc. This has been reported in issues such as #4044 and officially given a recommendation in streamnative/pulsar/issues/290, however, docker-compose/standalone-dashboard/docker-compose.yml is still outdated.

Modifications

  • Modified docker-compose/standalone-dashboard/docker-compose.yml to include --advertised-address with the name of the network host inside the docker-compose network that the dashboard can actually use.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

This change added tests and can be verified as follows:

  • without applying this patch, run docker-compose up, even after 2 minutes the dashboard still doesn't show tenants or topics
  • apply the patch and then run docker-compose up, refresh the dashboard UI after 20 seconds and the tenants and topics show up.

@bithavoc bithavoc changed the title [Issue 290][docs] Fix outdated docker-compose advertised address [Issue 4044][docs] Fix outdated docker-compose advertised address Feb 10, 2021
@sijie sijie added this to the 2.8.0 milestone Feb 11, 2021
@bithavoc
Copy link
Contributor Author

@sijie I see this PR is assigned to me but I'm having a hard time what's the next step from my side, I'm looking at the CONTRIBUTING guide and it states:

Commit: Once at least 2 Pulsar committers have approved the pull request, a Pulsar committer will merge it into the master branch (and potentially backport to stable branches in case of bug fixes).

So I guess I need another commiter to approve? Also the CI is complaining about something but I can't really tell what's the issue is, I can't seem retry the action either and the action step doesn't load the log output(somehow private?).

It's my first contribution to the project, can you give me some clues on how to proceed?

@sijie
Copy link
Member

sijie commented Feb 11, 2021

@bithavoc I assigned it to you to grant the contribution credit to you. We probably just need approval from another committer and then we can merge this pull request.

The CI failures are not unexpected. There is some flakiness on the CI. I will rerun those CI tests. You don't need to worry about it.

@merlimat merlimat merged commit 1674552 into apache:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulsar Dashboard Displays Very Little Information

3 participants