[WIP]Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl #9616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Feb 18, 2021
| } | ||
|
|
||
| protected ManagedLedgerFactoryImpl | ||
| createManagedLedgerFactory(ZooKeeper zkClient, |
Contributor
Author
There was a problem hiding this comment.
My IDE deal with the indent for me, I'm not sure what's the meaning of your 'fix indent' here. But I think the reason why the indent looks a little weird is that BookkeeperFactoryForCustomEnsemblePlacementPolicy is too long, the IDE has to format like this to make a line less than 120 chars.
Contributor
Author
|
@sijie PTAL |
Contributor
Author
|
/pulsarbot run-failure-checks |
Renkai
changed the title
Renkai
force-pushed
the
extendable-managed-ledger-factory
branch
8 times, most recently
from
d9f9082 to
0e1a84a
Compare
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Renkai
force-pushed
the
extendable-managed-ledger-factory
branch
from
c4983b1 to
9bc8532
Compare
Signed-off-by: Renkai <gaelookair@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ManagedLedgerinstead ofManagedLedgerImplinManagedLedgerFactoryImplto make theManagedLedgerFactoryImplextendable.As a result, some method declarations also moved from
ManagedLedgerImpltoManagedLedger.Next step of #9397 to allow supporting different storage implementations for Pulsar