[Flaky test] Reduce flakiness in MultiTopicsReaderTest by configuring infinite retention #9866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… infinite retention for namespace
Member
Author
|
@315157973 would you mind reviewing this change and taking a look at the flaky test issue #9636 ? Perhaps there's something else that can be done to reduce the flakiness the MultiTopicsReaderTest. The tests were introduced in #7518. |
Contributor
|
OK, I will check it tomorrow morning |
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MultiTopicsReaderTest.java
Show resolved
Hide resolved
merlimat
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an attempt to fix #9636. By configuring infinite retention for the namespace, it ensures that retention handling doesn't cause messages to get discarded before they are consumed and therefore reducing flakiness of the test.
Modifications
Configure infinite retention for the namespace used in the test.