[pulsar-broker] Namespace-resource use namespace name to fetch policy resource #9925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
codelipenghui,
jiazhai,
merlimat,
nkurihar and
sijie
Contributor
Author
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Apr 1, 2021
codelipenghui
approved these changes
Apr 4, 2021
Contributor
|
Hi Rajan @rdhabalia, Could you please help resolve the conflicts? so that we can merge it before 2.8.0 |
Contributor
|
@rdhabalia I will move this one to 2.9.0, feel free to move it back if it's need to release in 2.8.0 |
Contributor
Author
|
again it seems #11693 PR added with the same change and PR was merged. Closing this old PR as new PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Namespace-resources should be able to fetch policy with namespace and internal-path should be handled by the base-resources. It will make code clean and will be helpful for future abstraction.