RANGER-3166: fix setup.sh handling of property values having spaces #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
requested review from
Copilot,
dineshkumar-yadav,
fimugdha,
kumaab,
pradeepagrawal8184,
rameeshm,
spolavarpau1 and
vperiasamy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of property values that contain spaces in the setup.sh script by adding double quotes around variable expansions when passing them to the updatePropertyToFilePy function. This ensures that property values with spaces are correctly treated as single arguments rather than being split into multiple arguments.
Key Changes
- Added double quotes around
${newPropertyValue}variable expansion in allupdatePropertyToFilePyfunction calls throughout the script - This change affects approximately 100+ property update calls across different configuration sections including database, authentication, SSL/TLS, audit, and SSO settings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rebased PR #89 to latest master branch.
How was this patch tested?
CI tests run.