Skip to content

RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szetszwo merged 1 commit into from
Oct 24, 2023
Merged

RATIS-1918 Introduces parameters that separately control the shutdown of RaftServerProxy by JVMPauseMonitor #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ static void setSleepDeviationThreshold(RaftProperties properties, int thresholdM
setInt(properties::setInt, SLEEP_DEVIATION_THRESHOLD_KEY, thresholdMs);
}

String CLOSE_THRESHOLD_KEY = PREFIX + ".close.threshold";
TimeDuration CLOSE_THRESHOLD_DEFAULT = TimeDuration.valueOf(60, TimeUnit.SECONDS);
static TimeDuration closeThreshold(RaftProperties properties) {
return getTimeDuration(properties.getTimeDuration(CLOSE_THRESHOLD_DEFAULT.getUnit()),
CLOSE_THRESHOLD_KEY, CLOSE_THRESHOLD_DEFAULT, getDefaultLog());
}
static void setCloseThreshold(RaftProperties properties, int thresholdMs) {
setInt(properties::setInt, CLOSE_THRESHOLD_KEY, thresholdMs);
}

/**
* When bootstrapping a new peer, If the gap between the match index of the
* peer and the leader's latest committed index is less than this gap, we
Expand Down
4 changes: 2 additions & 2 deletions ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,11 +222,11 @@ String toString(RaftGroupId groupId, CompletableFuture<RaftServerImpl> f) {
id + "-impl"));

final TimeDuration sleepDeviationThreshold = RaftServerConfigKeys.sleepDeviationThreshold(properties);
final TimeDuration rpcSlownessTimeout = RaftServerConfigKeys.Rpc.slownessTimeout(properties);
final TimeDuration closeThreshold = RaftServerConfigKeys.closeThreshold(properties);
final TimeDuration leaderStepDownWaitTime = RaftServerConfigKeys.LeaderElection.leaderStepDownWaitTime(properties);
this.pauseMonitor = JvmPauseMonitor.newBuilder().setName(id)
.setSleepDeviationThreshold(sleepDeviationThreshold)
.setHandler(extraSleep -> handleJvmPause(extraSleep, rpcSlownessTimeout, leaderStepDownWaitTime))
.setHandler(extraSleep -> handleJvmPause(extraSleep, closeThreshold, leaderStepDownWaitTime))
.build();
this.threadGroup = threadGroup == null ? new ThreadGroup(this.id.toString()) : threadGroup;
}
Expand Down