SAMZA-2388: [Scala cleanup] Convert Util to Java #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t should be able to clean up after converting to Java
xinyuiscool
approved these changes
Nov 27, 2019
Contributor
xinyuiscool
left a comment
xinyuiscool
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for the case noted below, the intention of this PR is to not change any functionality. The intention is to just migrate logic to Java.
#1199 intended to migrate
Util.rewriteConfigto Java, but it also unintentionally changed some functionality (this PR changes the functionality back to the original functionality). That change applied each rewriter to the original config and then merged the results together. The original logic applied each rewriter to the rewritten result of the previous rewriter. Example cases where the overall rewritten result would be different: 1) one of the rewriters deletes a config (new code would do a merge so the config would not get deleted in the final result), 2) one rewriter depended on the result of another rewriter (new code would not allow rewriter to see results of previous rewriters).