SAMZA-2416 : Adding null-check before incrementing metrics for bytesSerialized #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonold
approved these changes
Dec 10, 2019
Contributor
bkonold
left a comment
bkonold
left a comment
There was a problem hiding this comment.
More of a documentation question, but are there cases where samza-provided serde's will behave similarly? Or fail on execution when provided a null to serialize?
The change LGTM
Contributor
Author
|
@bkonold Samza provided serdes dont run into this, user-defined serdes though can map non-null objects to null. |
rmatharu-zz
changed the title
rmatharu-zz
added a commit
to rmatharu-zz/samza
that referenced
this pull request
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding null-check before incrementing metrics for bytesSerialized
Symptom: User serde-serialization logic can choose to serialize non-null objects to a null, which implies delete the value. In this case, current code tries to increment the metrics using the size of the null and fails with an NPE.
Cause: Current code tries to increment the bytesSerialized metrics using the size of the null and fails with an NPE.
Fix: Added logic to skip metric value update if serde returns null.