Skip to content

Conversation

@cameronlee314
Copy link
Contributor

@cameronlee314 cameronlee314 commented Dec 13, 2019

Symptom: ./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopassword fails and does not respect the --nopassword parameter. Some of the documentation for testing does not have the correct commands for executing tests (i.e. missing yarn-integration-tests or standalone-integration-tests argument)

Cause:

  1. The slf4j binding was removed by SAMZA-2155: Remove log4j log4j2 dependency from samza-test #985, but the integration test depends on some of those stdout logs.
  2. An additional yarn-integration-tests or standalone-integration-tests argument was added by SAMZA-1748: Standalone failure tests. #554, but it looks like the argument parsing was not correctly updated to find the zopkio parameters. Also, not all of the test documentation was updated in that change.

Fix:

  1. Add log4j2 dependency and log4j2.xml back in to the samza-test module so the integration test package which pick it up and send logs to stdout.
  2. Fixed the argument parsing to use the correct argument slice. I also changed "${*:3}" to "${@:3}" since @ seems to be the cleaner in general (https://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and); although I think * still worked in this case.

Tests:

  1. Verified that ./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopassword and ./bin/integration-tests.sh standalone-integration-tests --nopassword both succeed and do not ask for a password.
  2. ./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests got to the stage where zopkio asked for a password.

Copy link
Contributor

@mynameborat mynameborat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@cameronlee314 cameronlee314 merged commit 454bfab into apache:master Dec 16, 2019
rmatharu-zz pushed a commit to rmatharu-zz/samza that referenced this pull request Jan 21, 2020
@cameronlee314 cameronlee314 deleted the integration_tests branch November 17, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants