SAMZA-2428: Clean up unused org.apache.samza.sql.util.ConfigUtil #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues: 1. org.apache.samza.sql.util.ConfigUtil is not used 2. it is the same name as org.apache.samza.util.ConfigUtil 3. its usage should be deprecated in favor of Config#subset(String prefix, boolean stripPrefix) Changes: delete org.apache.samza.sql.util.ConfigUtil Tests: build
bkonold
approved these changes
Jan 13, 2020
Contributor
|
@atoomula FYI |
atoomula
approved these changes
Jan 14, 2020
Contributor
|
@kw2542 Thanks for the changes. Merged the patch to trunk. |
rmatharu-zz
pushed a commit
to rmatharu-zz/samza
that referenced
this pull request
Jan 21, 2020
…che#1245) Issues: 1. org.apache.samza.sql.util.ConfigUtil is not used 2. it is the same name as org.apache.samza.util.ConfigUtil 3. its usage should be deprecated in favor of Config#subset(String prefix, boolean stripPrefix) Changes: delete org.apache.samza.sql.util.ConfigUtil Tests: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Changes: delete org.apache.samza.sql.util.ConfigUtil
API Changes:
None
Upgrade Instructions:
None
Usage Instructions:
None
Tests: build