SAMZA-2410: Update ClusterBasedJobCoordinator config retrieval logic from loader. #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 10, 2020 11:04
…to read config from loader Design: https://cwiki.apache.org/confluence/display/SAMZA/SEP-23%3A+Simplify+Job+Runner Changes: 1. Based on the existence of ENV_SUBMISSION_CONFIG, ClusterBasedJobCoordinator will alternatively deserilize ENV_SUBMISSION_CONFIG and load full job config from config loader factory. 2. Execute planning, create diagnostics stream and persist full job config back to coordinator stream when loading full job config from config loader. API Changes: N/A. This is part of a series PRs, detailed information will be provided in the last/main PR. Upgrade Instructions: N/A. This is part of a series PRs, detailed information will be provided in the last/main PR. Usage Instructions: N/A. This is part of a series PRs, detailed information will be provided in the last/main PR. Tests: End to end tested with Hello Samza job.
…pplicationRunner as well.
bkonold
reviewed
Jan 11, 2020
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
…oordinator not to merge final config with coordinator stream config to keep consistent with before.
bkonold
reviewed
Jan 13, 2020
bkonold
reviewed
Jan 14, 2020
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
…eric as it may contain config loader properties instead.
bkonold
approved these changes
Jan 15, 2020
Contributor
bkonold
left a comment
bkonold
left a comment
There was a problem hiding this comment.
LGTM, but look into the CI failure.
Contributor
cameronlee314
left a comment
cameronlee314
left a comment
There was a problem hiding this comment.
Can you please add unit tests?
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
added 4 commits
January 15, 2020 15:54
Override config first before applying config rewriters
Refactor ClusterBasedJobCoordinator to be testable
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/test/java/org/apache/samza/clustermanager/TestClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/test/java/org/apache/samza/util/TestConfigUtil.java
Outdated
Show resolved
Hide resolved
samza-core/src/test/java/org/apache/samza/util/TestConfigUtil.java
Outdated
Show resolved
Hide resolved
cameronlee314
approved these changes
Jan 17, 2020
added 2 commits
January 17, 2020 11:48
rmatharu-zz
pushed a commit
to rmatharu-zz/samza
that referenced
this pull request
Jan 21, 2020
…from loader. (apache#1248) 1. Based on the existence of ENV_SUBMISSION_CONFIG, ClusterBasedJobCoordinator will alternatively deserilize ENV_SUBMISSION_CONFIG and load full job config from config loader factory. 2. Execute planning, create diagnostics stream and persist full job config back to coordinator stream when loading full job config from config loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design:
https://cwiki.apache.org/confluence/display/SAMZA/SEP-23%3A+Simplify+Job+Runner
Changes:
API Changes:
N/A. This is part of a series PRs, detailed information will be provided in the last/main PR.
Upgrade Instructions:
N/A. This is part of a series PRs, detailed information will be provided in the last/main PR.
Usage Instructions:
N/A. This is part of a series PRs, detailed information will be provided in the last/main PR.
Tests:
End to end tested with Hello Samza job.