SAMZA-1838: Make some minor improvements to ExecutionPlanner #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vjagadish1989
left a comment
vjagadish1989
left a comment
There was a problem hiding this comment.
A couple of questions to understand the change better, thanks Ahmed!
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
vjagadish1989
approved these changes
Sep 9, 2018
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
shanthoosh
approved these changes
Sep 10, 2018
Contributor
shanthoosh
left a comment
shanthoosh
left a comment
There was a problem hiding this comment.
Minor comment, otherwise LGTM.
samza-core/src/main/java/org/apache/samza/execution/JobGraph.java
Outdated
Show resolved
Hide resolved
shanthoosh
reviewed
Sep 10, 2018
samza-core/src/main/java/org/apache/samza/execution/JobGraph.java
Outdated
Show resolved
Hide resolved
This commit includes the following changes:
- Fix case where ExecutionPlanner did not throw in response
to joining 2 input streams with different partition counts
- Improve some method names in ExecutionPlanner
- Improve some method/field names in JobGraph
- Make minor improvements to createJobGraph()
- Rewrite updateExistingPartitions() to make it a little easier to follow
- Use more constrained OperatorSpec types in the associations defined in
calculateJoinInputPartitions()
- Have calculateIntStreamPartitions() throw in response to bad config for
job.intermediate.stream.partitions
- Improve some error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@prateekm @vjagadish1989 whenever you get a chance. This is an initial set of mostly minor changes.